-
Notifications
You must be signed in to change notification settings - Fork 238
Add machine matrix #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add machine matrix #1382
Conversation
…o add-machine-matrix
|
Hi @victorapm . I took a quick look through this, even though I'm technically not a reviewer. :) It generally looks good to me. The only question I have is if you've diff'ed these saved files with ones from another machine to make sure there is nothing out of the ordinary. A few of the saved files had final residual numbers that were unexpected at first glance (I didn't dig into anything further). Thanks! |
|
Hi Rob, I was going to ask your review here after this is complete, so thanks for early input! I haven't done that yet, but sounds a good idea to me. Could you point out a couple of examples where you saw the unexpected residual numbers? I'll take a closer look at those |
| Final Relative Residual Norm = 0.000000e+00 | ||
|
|
||
| # Output file: cycred.out.3Dx.5 | ||
| Final Relative Residual Norm = 3.200000e+02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is one example. The exact zero results in this file also stand out, though they could be just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the results on matrix (this file) match the baselines used in tux (cycred.saved). I agree these residual values look weird though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rob, I checked the other saved.matrix files against the corresponding saved.aurora and they all look similar (a couple of iterations different in some cases and residual norms in the range of the requested error tolerance).
| # Output file: solvers.out.113 | ||
| GMRES Iterations = 25 | ||
| Final GMRES Relative Residual Norm = 8.744056e-09 | ||
| GMRES Iterations = 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason for this drop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the requested tolerance to 1e-3 so the residual norm computed on matrix and tux match to the precision printed here. This way, we can reuse the same .saved files from tux when running on matrix with host execution
rfalgout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Add test script for LC's matrix
TODO:
.savedfiles used by tux)Notes:
TEST_ij/solvers.shruns was lowered so we can reuse the same saved files as tux when building with GPU support but setting the execution policy to host